lkml.org 
[lkml]   [2017]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/staging/goldfish/goldfish_nand.c: Fixed Coding style Warnings.
Fix the subject.  The subsystem prefix is wrong and it's too vague.
Change it to:

[PATCH] Staging: goldfish: use __func__ instead of embedded function names


On Tue, Mar 14, 2017 at 08:53:50PM -0700, mshan wrote:
> Embedded function names are less appropriate to use when
> refactoring, can cause function renaming. Prefer the use
> of "%s", __func__ to embedded function names
>
> Signed-off-by: mshan <mohsinshan1k@gmail.com>

Please use your legal/formal name as if you were signing a legal
document. Also change the From header on your email to match.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-03-15 09:38    [W:0.075 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site