lkml.org 
[lkml]   [2017]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout()
On Fri, Mar 10, 2017 at 07:05:05PM +0530, simran singhal wrote:
> The function atomisp_set_stop_timeout on being called, simply returns
> back. The function hasn't been mentioned in the TODO and doesn't have
> FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been
> removed.
>
> This was done using Coccinelle.
>
> @@
> identifier f;
> @@
>
> void f(...) {
>
> -return;
>
> }
>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
> v1:
> -Change Subject to include name of function
> -change commit message to include the coccinelle script

You should also cc: the developers doing all of the current work on this
driver, Alan Cox, to get their comment if this really is something that
can be removed or not.

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-03-12 14:55    [W:0.032 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site