Messages in this thread | | | Date | Wed, 1 Mar 2017 17:26:06 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 2/4] perf tools: Introduce cpu_map__snprint_mask() |
| |
Em Sat, Feb 25, 2017 at 01:27:34PM +0900, Namhyung Kim escreveu: > On Fri, Feb 24, 2017 at 06:08:53PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, Feb 24, 2017 at 10:12:49AM +0900, Namhyung Kim escreveu: > > util/cpumap.c:679:8: error: comparison is always true due to limited range of data type [-Werror=type-limits] > > if (0 <= val && val <= 9) > > ^~ > > Are you ok with the patch below?
> I'd rather change hex_char() instead. How about this?
Ok, applying by hand, somehow it didn't apply using git-am...
- Arnaldo
> +++ b/tools/perf/util/cpumap.c > @@ -674,11 +674,11 @@ size_t cpu_map__snprint(struct cpu_map *map, char *buf, size_t size) > return ret; > } > > -static char hex_char(char val) > +static char hex_char(unsigned char val) > { > - if (0 <= val && val <= 9) > + if (val < 10) > return val + '0'; > - if (10 <= val && val < 16) > + if (val < 16) > return val - 10 + 'a'; > return '?'; > }
| |