lkml.org 
[lkml]   [2017]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 06/13] lockdep: Implement crossrelease feature
On Wed, Mar 01, 2017 at 02:17:07PM +0900, Byungchul Park wrote:
> > > +void lock_commit_crosslock(struct lockdep_map *lock)
> > > +{
> > > + struct cross_lock *xlock;
> > > + unsigned long flags;
> > > +
> > > + if (!current->xhlocks)
> > > + return;
> > > +
> > > + if (unlikely(current->lockdep_recursion))
> > > + return;
> > > +
> > > + raw_local_irq_save(flags);
> > > + check_flags(flags);
> > > + current->lockdep_recursion = 1;
> > > +
> > > + if (unlikely(!debug_locks))
> > > + return;
> > > +
> > > + if (!graph_lock())
> > > + return;
> > > +
> > > + xlock = &((struct lockdep_map_cross *)lock)->xlock;
> > > + if (atomic_read(&xlock->ref) > 0 && !commit_xhlocks(xlock))
> >
> > You terminate with graph_lock() held.
>
> Oops. What did I do? I'll fix it.

I remembered it. It's no problem because it would terminate there, only
if _both_ 'xlock->ref > 0' and 'commit_xhlocks returns 0' are true.
Otherwise, it will unlock the lock safely.

\
 
 \ /
  Last update: 2017-03-02 03:53    [W:0.204 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site