lkml.org 
[lkml]   [2017]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hid: usbhid: usbkbd: fix checkpatch.pl issues
On Wed, Mar 01, 2017 at 09:59:31PM +0200, Avraham Shukron wrote:
> >
> > This kind of change is definitely not helpful. The original table was
> > Nx16, you converted it to Nx14. Why do you think original table used 16
> > columns?
> >
> > Regardless, it's a very old driver, just let it be.
> >
> > Thanks.
> >
>
> I can make it Nx8 :)
>
> Seriously now - I don't understand what is so wrong with checkpatch fixes?
> I'm a new to kernel development, and the natural place to start is to do some
> coding style fixes.

Start doing this in the drivers/staging/ portion of the kernel. Other
places usually do not want these types of changes for the reasons people
have given you already.

That is what drivers/staging/ is for, to learn the process. Please
stick to it there.

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-03-01 22:00    [W:0.069 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site