lkml.org 
[lkml]   [2017]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear
2017-02-28 11:29+0000, James Hogan:
> On Mon, Feb 27, 2017 at 11:03:51AM +0100, David Hildenbrand wrote:
>> Am 27.02.2017 um 09:45 schrieb Andrew Jones:
>> > On Fri, Feb 24, 2017 at 08:50:01PM +0100, Radim Krčmář wrote:
>> >> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
>> >> ---
>> >> arch/mips/kvm/emulate.c | 1 -
>> >> 1 file changed, 1 deletion(-)
>> >>
>> >> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
>> >> index 552ae2b5e911..70614ca41744 100644
>> >> --- a/arch/mips/kvm/emulate.c
>> >> +++ b/arch/mips/kvm/emulate.c
>> >> @@ -865,7 +865,6 @@ enum emulation_result kvm_mips_emul_wait(struct kvm_vcpu *vcpu)
>> >> * check if any I/O interrupts are pending.
>> >> */
>> >> if (kvm_request_test_and_clear(KVM_REQ_UNHALT, vcpu)) {
>> >> - __kvm_request_clear(KVM_REQ_UNHALT, vcpu);
>> >> vcpu->run->exit_reason = KVM_EXIT_IRQ_WINDOW_OPEN;
>> >> }
>> >
>> > should remove the {} too.
>> >
>>
>> With that,
>>
>> Reviewed-by: David Hildenbrand <david@redhat.com>
>
> and with that:
>
> Acked-by: James Hogan <james.hogan@imgtec.com>

I'll do that when applying or posting v3,

thanks for catching that.

\
 
 \ /
  Last update: 2017-03-01 18:58    [W:0.253 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site