lkml.org 
[lkml]   [2017]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [v2] Input: pwm-beeper: support customized freq for SND_BELL
From
Date
Hello Dimitry,

Am 28.02.2017 um 07:20 schrieb Dmitry Torokhov:
> On February 27, 2017 10:13:43 PM PST, Heiko Schocher <hs@denx.de> wrote:
>> Hello David,
>>
>> Am 28.02.2017 um 06:30 schrieb David Lechner:
>>> On 02/27/2017 11:19 PM, Heiko Schocher wrote:
>>>> Hello David,
>>>>
>>>> Am 27.02.2017 um 19:11 schrieb David Lechner:
>>>>> On 02/20/2017 02:37 AM, Heiko Schocher wrote:
>>>>>> From: Guan Ben <ben.guan@cn.bosch.com>
>>>>>>
>>>>>> extend the pwm-beeper driver to support customized frequency
>>>>>> for SND_BELL from device tree.
>>>>>>
>>>>>> Signed-off-by: Guan Ben <ben.guan@cn.bosch.com>
>>>>>> Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
>>>>>> [hs@denx.de: adapted to 4.10-rc7]
>>>>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>>>>> ---
>>>>>>
>>>>>> Changes in v2:
>>>>>> - add comment from Rob Herring:
>>>>>> rename property name "bell-frequency" to "beeper-hz"
>>>>>
>>>>> Is there a separate patch for the devicetree bindings
>> documentation?
>>>>
>>>> No, it is in this patch ... In the meantime I got an
>>>> Acked-by from Rob Herring ...
>>>>
>>>
>>> What I should have said is that, in general, I think it is preferred
>> to have the device tree
>>> bindings as a separate patch from the code changes.
>>
>> I can split this into 2 patches ...
>
> Don't - since Rob already asked DT change you don't need to post to device tree list again and I'll merge them back together since they do not make sense separately.

Ok, I post a v3 with the changes suggested from David and Rob soon,
without splitting.

Thanks!

bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

\
 
 \ /
  Last update: 2017-03-01 06:24    [W:0.047 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site