Messages in this thread | | | Date | Wed, 1 Mar 2017 23:21:33 +0900 | From | Namhyung Kim <> | Subject | Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view |
| |
Hi Peter,
On Wed, Mar 01, 2017 at 03:08:33PM +0100, Peter Zijlstra wrote: > On Wed, Mar 01, 2017 at 10:58:05PM +0900, Namhyung Kim wrote: > > On Wed, Mar 01, 2017 at 04:59:52AM +0900, Taeung Song wrote: > > > The current source code view using 'objdump -S' > > > has several limitations regarding line numbers of each soure > > > code line and confusing mixed soure code & diassembly view. > > > > > > So not use the '-S' option any more and > > > add the new reable source code view with > > > correct line numbers and source code per each symbol(function) > > > using new struct source_code. > > > > I like this "source-only" annotation, but some people still might want > > to see the "mixed" annotation. So I think you need to keep it and > > provide another option for the source-only mode. And then we can > > change the default later. > > What's the point of source-only? You can't even see what it is that is > expensive.
???
This is to show source code + overhead (for each line). People can see which line of their source is expensive. I think it's way more intuitive for most developers..
Thanks, Namhyung
| |