Messages in this thread | | | Date | Tue, 28 Feb 2017 10:24:17 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v2 2/3] spi: allocate spi_board_info entries one by one |
| |
On Tue, Feb 28, 2017 at 09:16:50AM +0000, Mark Brown wrote: > On Mon, Feb 27, 2017 at 08:18:56PM -0800, Dmitry Torokhov wrote: > > Lists of spi_board_info entries registered with spi_register_board_info() > > can be quite long; instead of forcing memory allocator find contagious > > Do you have numbers on that?
Hm, so the largest array seems to be in arch/blackfin/mach-bf537/boards/stamp.c at max of 43 entries. The new board info is ether 60 or 72 bytes, so we get 2 or 3K table. Not above page, but still could be packed I think.
If we decide that we want to keep single chunk I'll just change the allocation to kcalloc. Let me know.
We should probably redo patch #1 to avoid allocating empty property sets anyway.
Thanks.
-- Dmitry
| |