lkml.org 
[lkml]   [2017]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V3 2/3] sched/deadline: Throttle a constrained deadline task activated after the deadline
From
Date
On 02/28/2017 11:07 AM, Daniel Bristot de Oliveira wrote:
> + if (!pi_se->dl_throttled && dl_is_constrained(pi_se))
> + dl_check_constrained_dl(pi_se);
> +

me--, it should be &p->dl, not pi_se. This is not causing problems in
the test case because pi_se = &p->dl, but this would be a problem if we
were activating the task in a PI case: it would check the pi-waiter, not
the task being awakened (p).

In the dl_check_constrained_dl(), the patch is already avoiding
throttling if the task is "dl_boosted." So it is ready to avoid
throttling the task in the PI control.

Cooking a v4, sorry for the noise.

-- Daniel

\
 
 \ /
  Last update: 2017-02-28 19:22    [W:0.102 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site