Messages in this thread | | | Subject | Re: [PATCH v6 1/6] i2c: designware: Cleaning and comment style fixes. | From | Jarkko Nikula <> | Date | Tue, 28 Feb 2017 17:07:09 +0200 |
| |
Hi
Sorry the delay.
On 02/15/17 15:12, Andy Shevchenko wrote: > On Wed, 2017-02-15 at 12:22 +0000, Luis Oliveira wrote: >> The purpose of this commit is to fix some comments and styling in the >> existing code due to the need of reuse this code. What is being made >> here is: >> >> - Sorted the headers files >> - Corrected some comments style (capital letters, lowcase i2c) >> - Reverse tree in the variables declaration >> - Add/remove empty lines and tabs where needed >> - Fix of misspelled word "endianness" and "transferred" >> - Replaced the return variable "r" with the more standard "ret" >> >> The value of this, besides the rules of coding style, is because I >> will use this code after and it will make my future patch a lot bigger >> and >> complicated to review. The work here won't bring any additional work >> to >> backported fixes because is just style and reordering. >> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > >> Signed-off-by: Luis Oliveira <lolivei@synopsys.com> >> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Unfortunately this doesn't apply anymore due we had to revert commit 63d0f0a6952a ("i2c: designware: detect when dynamic tar update is possible") for v4.10. Could you rebase and resend.
-- Jarkko
| |