Messages in this thread | | | From | "Reshetova, Elena" <> | Subject | RE: [PATCH 1/9] tools: convert cgroup_sel.refcnt from atomic_t to refcount_t | Date | Wed, 22 Feb 2017 14:29:18 +0000 |
| |
> Em Tue, Feb 21, 2017 at 05:34:55PM +0200, Elena Reshetova escreveu: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situations. > > #define __CGROUP_H__ > > > > -#include <linux/atomic.h> > > +#include <linux/refcount.h> > > So this is the first one, I was expecting the copy from > include/linux/refcount.h to be made to tools/include/linux/refcount.h, > as was done for tools/include/linux/atomic.h and all the other stuff in > tools/include/ > > See: > > commit c4b6014e8bb0c8d47fe5c71ebc604f31091e5d3f > Author: Arnaldo Carvalho de Melo <acme@redhat.com> > Date: Mon Jul 11 10:28:48 2016 -0300 > > tools: Add copy of perf_event.h to tools/include/linux/ > > -------------- > > For one of the reasons we've been doing this.
Hm.. I have taken a look on it and I am confused. refcount.h is not exactly standalone header and seems to bring in quite some many dependencies to other headers (linux/bug.h, linux/mutex.h etc.), which are not present in tools headers dirs. I tried to compile perf tool as a start, copied the refcount.h to tools/include/linux/ and somewhere after it wanted me to bring the 10th header I stopped, because this cannot be right, or?
Best Regards, Elena.
| |