Messages in this thread | | | Subject | Re: [PATCH v2] Staging: comedi: drivers: comedi_test: Avoid multiple line dereference | From | Ian Abbott <> | Date | Wed, 22 Feb 2017 10:35:32 +0000 |
| |
On 21/02/17 17:25, Cheah Kok Cheong wrote: > Fix checkpatch warning "Avoid multiple line dereference" > using a pointer variable to avoid line wrap. > > Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com> > --- > > V2: > -Use pointer instead of normal variable - Ian > -Variable is to be used as "write destination" and > not as "read source" - Ian > > drivers/staging/comedi/drivers/comedi_test.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/comedi_test.c b/drivers/staging/comedi/drivers/comedi_test.c > index 2a063f0..ccfd642 100644 > --- a/drivers/staging/comedi/drivers/comedi_test.c > +++ b/drivers/staging/comedi/drivers/comedi_test.c > @@ -480,11 +480,11 @@ static void waveform_ao_timer(unsigned long arg) > /* output the last scan */ > for (i = 0; i < cmd->scan_end_arg; i++) { > unsigned int chan = CR_CHAN(cmd->chanlist[i]); > + unsigned short *pd; > > - if (comedi_buf_read_samples(s, > - &devpriv-> > - ao_loopbacks[chan], > - 1) == 0) { > + pd = &devpriv->ao_loopbacks[chan]; > + > + if (!comedi_buf_read_samples(s, pd, 1)) { > /* unexpected underrun! (cancelled?) */ > async->events |= COMEDI_CB_OVERFLOW; > goto underrun; >
Looks good, thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |