lkml.org 
[lkml]   [2017]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3 v2] usb: host: fotg2: add device tree probing
    On Thu, Feb 09, 2017 at 03:20:49PM +0100, Hans Ulli Kroll wrote:
    >
    > Add device tree probe for fotg2 driver
    >
    > v2:
    > fix in wrong MODULE_DEVICE_TABLE
    >
    > Signed-off-by: Hans Ulli Kroll <ulli.kroll@googlemail.com>
    > ---
    > drivers/usb/host/fotg210-hcd.c | 19 +++++++++++++++++++
    > 1 file changed, 19 insertions(+)
    >
    > diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
    > index 9d0b0518290a..2acc51b0be5a 100644
    > --- a/drivers/usb/host/fotg210-hcd.c
    > +++ b/drivers/usb/host/fotg210-hcd.c
    > @@ -23,6 +23,7 @@
    > * Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
    > */
    > #include <linux/module.h>
    > +#include <linux/of.h>
    > #include <linux/device.h>
    > #include <linux/dmapool.h>
    > #include <linux/kernel.h>
    > @@ -5600,6 +5601,15 @@ static int fotg210_hcd_probe(struct platform_device *pdev)
    > if (usb_disabled())
    > return -ENODEV;
    >
    > + /* Right now device-tree probed devices don't get dma_mask set.
    > + * Since shared usb code relies on it, set it here for now.
    > + * Once we have dma capability bindings this can go away.
    > + */
    > +
    > + retval = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
    > + if (retval)
    > + goto fail_create_hcd;
    > +

    This change doesn't match up with what the changelog describes :(

    \
     
     \ /
      Last update: 2017-02-10 14:36    [W:3.294 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site