Messages in this thread | | | From | Masahiro Yamada <> | Date | Sun, 10 Dec 2017 01:27:42 +0900 | Subject | Re: [PATCH] kconfig: Remove menu_end_entry() |
| |
2017-10-05 11:36 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>: > menu_end_entry() is empty and completely unused as far as I can tell: > > $ git log -G menu_end_entry --oneline > a02f057 [PATCH] kconfig: improve error handling in the parser > 1da177e Linux-2.6.12-rc2 > > Last one is the initial Git commit, where menu_end_entry() is empty as > well. I couldn't find anything that redefined it on Google either. > > It might be a debugging helper for setting a breakpoint after each > config, menuconfig, and comment is parsed. IMO it hurts more than it > helps in that case by making the parsing code look more complicated at a > glance than it really is, and I suspect it doesn't get used much. > > Tested by running the Kconfiglib test suite, which indirectly verifies > that the .config files generated by the C implementation for each > defconfig file in the kernel stays the same. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > ---
Removing menu_end_entry() should be OK, but it is tedious to sync *.y and *_shipped.
I'd like to apply v2 (https://patchwork.kernel.org/patch/9992029/) on top of my patch (https://patchwork.kernel.org/patch/10103743/)
-- Best Regards Masahiro Yamada
| |