Messages in this thread | | | Subject | Re: [PATCH v2 18/19] ASoC: tlv320aic31xx: Add headphone/headset detection | From | "Andrew F. Davis" <> | Date | Wed, 6 Dec 2017 11:25:15 -0600 |
| |
On 12/01/2017 07:41 AM, Mark Brown wrote: > On Wed, Nov 29, 2017 at 03:32:59PM -0600, Andrew F. Davis wrote: >> This device can detect the insertion/removal of headphones and headsets. >> Enable reporting this status by enabling this interrupt and forwarding >> this to upper-layers if a jack has been defined. >> >> This jack definition and the resulting operation from a jack detection >> event must currently be defined by sound card platform code until CODEC >> outputs to jack mappings can be defined generically. > > This only does half the job, there's no way for anything to specify a > jack here. >
Other CODECs drivers expose some kind of platform/machine specific function(s) to send the jack definition to the CODEC, we seem to be missing a generic way to report jack information up to the machine layer driver.
Perhaps a struct with a jack enable/disable and call-back functions could be created when registering the codec/platform component driver? Then machines can hook to this as they need?
| |