lkml.org 
[lkml]   [2017]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: jsm_tty: Fix a possible null pointer dereference in two functions
From
Date


On 11/29/2017 04:19 PM, SF Markus Elfring wrote:
>>> It's pretty unlikely, but it is an actual defect.
>>
>> No it is not, those variables will never be set to NULL,
>> so this can never be triggered. Walk up the call chain.
>
> If the involved software developers are convinced about the validity
> of this pointer:
>
> How do you think about to delete the following condition check
> instead in the discussed function implementations?
>
> if (!ch)
> return;
>
>
> Regards,
> Markus
>

Thanks for the fix.
I was on vacation - but now seeing all the analysis made here, if "ch"
can't be NULL then please go ahead and remove the check =)
I observed that this check comes from before Git, so really ancient code...

Cheers,


Guilherme

\
 
 \ /
  Last update: 2017-12-06 17:17    [W:6.901 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site