lkml.org 
[lkml]   [2017]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h
From
Date


Am 06.12.2017 um 12:23 schrieb Dan Carpenter:
> On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote:
>>> diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h
>>> index babe597e2ec6..5247e9269de9 100644
>>> --- a/drivers/staging/pi433/rf69_enum.h
>>> +++ b/drivers/staging/pi433/rf69_enum.h
>>> @@ -18,9 +18,9 @@
>>> #ifndef RF69_ENUM_H
>>> #define RF69_ENUM_H
>>> -enum optionOnOff {
>>> - optionOff,
>>> - optionOn
>>> +enum option_on_off {
>>> + OPTION_OFF,
>>> + OPTION_ON
>>> };
>>> enum mode {
>>>
>>
>> Hi Simon,
>>
>> nice work.
>>
>> Thank you very much for all the style fixes :-)
>>
>
>
> Wow... This was the one patch I thought was going to sink this
> patchset...

I don't get that. What do you mean?

> Isn't enum optionOnOff part of the userspace headers?
>
> I thought we weren't allowed to change that.

All enums are for user space (or inteded to be used in userspace in
future). Didn't introduce enums for internal use.

Reagrds,
Marcus

\
 
 \ /
  Last update: 2017-12-06 11:32    [W:0.085 / U:1.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site