Messages in this thread | | | Subject | Re: [PATCH v2] pata_pdc2027x: Fix coding sytle errors | From | Sergei Shtylyov <> | Date | Wed, 6 Dec 2017 12:43:14 +0300 |
| |
On 12/5/2017 9:26 PM, Arvind Yadav wrote:
> Fix these checkpatch.pl errors: > Fix checkpatch.pl error:
Why repeat it twice?
> ERROR: space prohibited before open square bracket '['. > > ERROR: space prohibited after that '~' (ctx:WxW) > + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA)); > > ERROR: spaces required around that '?' (ctx:VxW) > + long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ; > > ERROR: that open brace { should be on the previous line > + const struct ata_port_info *ppi[] = > + { &pdc2027x_port_info[board_idx], NULL }; > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > changes in v2: > Subject and description was not correct. > *s/sytle error/style errors/ in the patch summary
You didn't really fix the subject. :-/
[...]
MBR, Sergei
| |