lkml.org 
[lkml]   [2017]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 5/9] x86/uv: Use the right tlbflush API
    From
    Date
    On 12/5/17 6:34 AM, Peter Zijlstra wrote:
    > Since uv_flush_tlb_others() implements flush_tlb_others() which is
    > about flushing user mappings, we should use __flush_tlb_single(),
    > which too is about flushing user mappings.
    >
    > Cc: Andrew Banman<abanman@hpe.com>
    > Cc: Mike Travis<mike.travis@hpe.com>
    > Signed-off-by: Peter Zijlstra (Intel)<peterz@infradead.org>
    > ---
    > arch/x86/platform/uv/tlb_uv.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > --- a/arch/x86/platform/uv/tlb_uv.c
    > +++ b/arch/x86/platform/uv/tlb_uv.c
    > @@ -299,7 +299,7 @@ static void bau_process_message(struct m
    > local_flush_tlb();
    > stat->d_alltlb++;
    > } else {
    > - __flush_tlb_one(msg->address);
    > + __flush_tlb_single(msg->address);
    > stat->d_onetlb++;
    > }
    > stat->d_requestee++;

    This looks like the right thing to do. We'll be testing it and complain later if
    we find any problems, but I'm not expecting any since this patch looks to
    maintain our status quo.

    Best,

    Andrew

    \
     
     \ /
      Last update: 2017-12-05 22:14    [W:3.949 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site