lkml.org 
[lkml]   [2017]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] checkpatch: warn for use of %px
On Tue, Dec 05, 2017 at 07:27:18AM -0800, Joe Perches wrote:
> On Tue, 2017-12-05 at 20:44 +1100, Tobin C. Harding wrote:
> > On Mon, Dec 04, 2017 at 11:24:24PM -0800, Joe Perches wrote:
> > > On Tue, 2017-12-05 at 08:17 +1100, Tobin C. Harding wrote:
> > > > Usage of the new %px specifier potentially leaks sensitive
> > > > inforamtion. Printing kernel addresses exposes the kernel layout in
> > >
> > > information
>
> > I don't understand this comment? Do you mean the wording is wrong?
> > I'll re-word as suggested below.
>
> It's just a spelling typo correction.

ha ha, note to self - be careful doing kernel email late at night :)

> []
> > > > Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> > > > Signed-off-by: Tobin C. Harding <me@tobin.cc>
> > > > Co-Developed-by: Joe Perches <joe@perches.com>
> > > > Are you happy with this tagging? Needs your signed-off-by still.
>
> I think signatures tags are pretty freeform and
> I'm not particularly concerned about them.
>
> I think Andrew Morton may object and change it
> or remove it. Have an:
>
> Acked-by: Joe Perches <joe@perches.com>

Cool, will add and re-spin

thanks,
Tobin.

\
 
 \ /
  Last update: 2017-12-05 21:28    [W:0.044 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site