lkml.org 
[lkml]   [2017]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] HID: elecom: rewrite report fixup for EX-G and future mice
    On Mon, Dec 04, 2017 at 08:55:50PM +0000, Tomasz Kramkowski wrote:
    > +static void mouse_button_fixup(struct hid_device *hdev,
    > + __u8 *rdesc, unsigned int *rsize,
    > + int nbuttons)

    I've just remembered what has been bugging me yesterday when I was
    reviewing this patch. I had come to the realisation (and then
    subsequently forgotten) that this function should probably return __u8 *
    and also get assigned to rdesc on the other end. It seems to me that it
    makes most sense to allow for the possibility (although slim) of this
    function eventually being expanded to actually replace the report
    descriptor (technically the full report descriptor contains a bunch of
    useless crap like INPUT reports for media keys and the FEATURE report
    which as far as I can tell is totally useless or may or may not be some
    tactic by ELECOM to future-proof their firmware).

    The other option would be to make rsize not a pointer because it doesn't
    need to be. But that kind of makes the flow of the two functions
    somewhat inconsistent. I'm not sure if I'm alone in that feeling.

    Anyway, I should have written this down when I first caught it, sorry
    for the noise. I'll let you guys review this patch and give any other
    feedback you might have and I'll try to get a v2 as soon as possible
    afterwards.

    --
    Tomasz Kramkowski | GPG: 40B037BA0A5B8680 | Web: https://the-tk.com/

    \
     
     \ /
      Last update: 2017-12-05 21:19    [W:6.173 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site