Messages in this thread | | | Date | Sun, 3 Dec 2017 22:40:14 +0530 | From | Vinod Koul <> | Subject | Re: [alsa-devel] [PATCH v4 12/15] soundwire: cdns: Add sdw_master_ops and IO transfer support |
| |
On Fri, Dec 01, 2017 at 06:02:24PM -0600, Pierre-Louis Bossart wrote: > > > struct sdw_cdns { > > struct device *dev; > > struct sdw_bus bus; > > unsigned int instance; > >+ u32 response_buf[0x80]; > > last nit-pick: use a #define for the size.
okay last one huh :) yeah will add.
> Also are you sure about the value? I vaguely recall that the FIFO was > 32-deep, you are confusing bytes and words here?
I dont think this is related to FIFO depth, this is buffer to hold values. Will check though..
-- ~Vinod
| |