Messages in this thread | | | Date | Fri, 29 Dec 2017 17:46:02 +0000 | From | Jonathan Cameron <> | Subject | Re: [PATCH v2 1/7] iio: adc: ina2xx: Remove bogus cast for data argument |
| |
On Thu, 21 Dec 2017 19:31:32 +0100 Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote:
> iio_push_to_buffers_with_timestamp expects a void pointer, so the cast > is both unnecessary and misleading. > > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> Hi Stefan,
I applied the first few patches the first time around. Please drop them from new versions - if nothing else if confuses me ;)
> --- > > Changes in v2: None > > drivers/iio/adc/ina2xx-adc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c > index ddf878163bf9..3195f8754c3b 100644 > --- a/drivers/iio/adc/ina2xx-adc.c > +++ b/drivers/iio/adc/ina2xx-adc.c > @@ -767,8 +767,7 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev) > > time_b = iio_get_time_ns(indio_dev); > > - iio_push_to_buffers_with_timestamp(indio_dev, > - (unsigned int *)data, time_a); > + iio_push_to_buffers_with_timestamp(indio_dev, data, time_a); > > return (unsigned long)(time_b - time_a) / 1000; > };
| |