Messages in this thread | | | Date | Wed, 27 Dec 2017 16:19:04 +0100 | From | Greg KH <> | Subject | Re: [PATCH v2 1/9] ufs: sysfs: device descriptor |
| |
On Wed, Dec 27, 2017 at 05:13:39PM +0200, Stanislav Nijnikov wrote: > +EXPORT_SYMBOL(ufs_sysfs_add_device_management);
Whhy is this exported? What external module uses it?
> + > +void ufs_sysfs_remove_device_management(struct ufs_hba *hba) > +{ > + sysfs_remove_groups(&hba->dev->kobj, ufs_sysfs_groups); > +} > +EXPORT_SYMBOL(ufs_sysfs_remove_device_management); > + > +MODULE_LICENSE("GPL");
Are you sure you didn't just put 2 module license fields in the same module?
Other than those nits, looks good!
thanks,
greg k-h
| |