Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 24 Dec 2017 18:23:15 +0000 | From | Aaron Tomlin <> | Subject | Re: [PATCH/RFC] perf report: Add option to change offset format when address is specified as a sort_key |
| |
On Sat 2017-12-23 00:59 +0100, Jiri Olsa wrote: [ ... ] > not sure we've already discussed that, but this could be default?
Probably it is best to keep the default behaviour.
I'd prefer a hexadecimal address offset, as the default, however perhaps someone is happy with the current default (decimal).
> if not, I think the hex option should be part of -g option arg, maybe like:
Does it have to be?
> -g graph,callee,xaddress
Not sure - adding another sort_key seems odd to me.
But if you insist, perhaps address[=hex] would be cleaner?
Otherwise I would prefer --hex.
Regards,
-- Aaron Tomlin [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |