lkml.org 
[lkml]   [2017]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 02/19] fs: don't take the i_lock in inode_inc_iversion
    Date
    From: Jeff Layton <jlayton@redhat.com>

    The rationale for taking the i_lock when incrementing this value is
    lost in antiquity. The readers of the field don't take it (at least
    not universally), so my assumption is that it was only done here to
    serialize incrementors.

    If that is indeed the case, then we can drop the i_lock from this
    codepath and treat it as a atomic64_t for the purposes of
    incrementing it. This allows us to use inode_inc_iversion without
    any danger of lock inversion.

    Note that the read side is not fetched atomically with this change.
    The assumption here is that that is not a critical issue since the
    i_version is not fully synchronized with anything else anyway.

    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    ---
    include/linux/iversion.h | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/include/linux/iversion.h b/include/linux/iversion.h
    index bb50d27c71f9..e08c634779df 100644
    --- a/include/linux/iversion.h
    +++ b/include/linux/iversion.h
    @@ -104,12 +104,13 @@ inode_set_iversion_queried(struct inode *inode, const u64 new)
    static inline bool
    inode_maybe_inc_iversion(struct inode *inode, bool force)
    {
    - spin_lock(&inode->i_lock);
    - inode->i_version++;
    - spin_unlock(&inode->i_lock);
    + atomic64_t *ivp = (atomic64_t *)&inode->i_version;
    +
    + atomic64_inc(ivp);
    return true;
    }

    +
    /**
    * inode_inc_iversion - forcibly increment i_version
    * @inode: inode that needs to be updated
    --
    2.14.3
    \
     
     \ /
      Last update: 2017-12-22 13:13    [W:2.407 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site