lkml.org 
[lkml]   [2017]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] mm: Make follow_pte_pmd an inline
    On Tue, Dec 19, 2017 at 08:58:22AM -0800, Matthew Wilcox wrote:
    > From: Matthew Wilcox <mawilcox@microsoft.com>
    >
    > The one user of follow_pte_pmd (dax) emits a sparse warning because
    > it doesn't know that follow_pte_pmd conditionally returns with the
    > pte/pmd locked. The required annotation is already there; it's just
    > in the wrong file.

    Can you help me find the required annotation that is already there but in the
    wrong file?

    This does seem to quiet a lockep warning in fs/dax.c, but I think we still
    have a related one in mm/memory.c:

    mm/memory.c:4204:5: warning: context imbalance in '__follow_pte_pmd' - different lock contexts for basic block

    Should we deal with this one as well?

    \
     
     \ /
      Last update: 2017-12-21 22:31    [W:6.730 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site