Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 21 Dec 2017 11:27:52 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] Do not hash userspace addresses in fault handlers |
| |
On Tue, 19 Dec 2017, Kees Cook wrote: > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > index febf6980e653..06fe3d51d385 100644 > --- a/arch/x86/mm/fault.c > +++ b/arch/x86/mm/fault.c > @@ -860,7 +860,7 @@ show_signal_msg(struct pt_regs *regs, unsigned long error_code, > if (!printk_ratelimit()) > return; > > - printk("%s%s[%d]: segfault at %lx ip %p sp %p error %lx", > + printk("%s%s[%d]: segfault at %lx ip %px sp %px error %lx", > task_pid_nr(tsk) > 1 ? KERN_INFO : KERN_EMERG, > tsk->comm, task_pid_nr(tsk), address, > (void *)regs->ip, (void *)regs->sp, error_code);
For that part:
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
| ![\](/images/icornerr.gif) |