lkml.org 
[lkml]   [2017]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled
    Date
    Hello,

    Commit 5e572cab92f0 ("tpm: Enable CLKRUN protocol for Braswell systems")
    added logic in the TPM TIS driver to disable the Low Pin Count CLKRUN
    signal during TPM transactions.

    Unfortunately this breaks other devices that are attached to the LPC bus
    like for example PS/2 mouse and keyboards.

    The bug was reported to the Fedora kernel [0] and the kernel bugzilla [1].
    This issue and the propossed solution were discussed in this [2] thread,
    and the reporter (Jame Ettle) confirmed that his system works again after
    the fix in this series.

    The patches are based on top or Jarkko Sakkinen's linux-tpmdd [3] tree.

    James,

    Even when there shouldn't be any functional changes, I included some other
    fixes / cleanups in this series so it would be great if you can test them
    again. I can't because I don't have access to a machine affected by this.

    [0]: https://bugzilla.redhat.com/show_bug.cgi?id=1498987
    [1]: https://bugzilla.kernel.org/show_bug.cgi?id=197287
    [2]: https://patchwork.kernel.org/patch/10119417/
    [3]: git.infradead.org/users/jjs/linux-tpmdd.git

    Best regards,
    Javier


    Javier Martinez Canillas (4):
    tpm: fix access attempt to an already unmapped I/O memory region
    tpm: delete the TPM_TIS_CLK_ENABLE flag
    tpm: follow coding style for variable declaration in
    tpm_tis_core_init()
    tpm: only attempt to disable the LPC CLKRUN if is already enabled

    drivers/char/tpm/tpm_tis.c | 17 +----------------
    drivers/char/tpm/tpm_tis_core.c | 24 +++++++++++++++++-------
    drivers/char/tpm/tpm_tis_core.h | 1 -
    3 files changed, 18 insertions(+), 24 deletions(-)

    --
    2.14.3

    \
     
     \ /
      Last update: 2017-12-20 12:36    [W:2.792 / U:1.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site