lkml.org 
[lkml]   [2017]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] clk: check ops pointer on clock register
On Mon, Dec 18, 2017 at 8:03 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 12/18, Jerome Brunet wrote:
>> Nothing really prevents a provider from (trying to) register a clock
>> without providing the clock ops structure.
>>
>> We do check the individual fields before using them, but not the
>> structure pointer itself. This may have the usual nasty consequences when
>> the pointer is dereferenced, mostly likely when checking one the field
>> during the initialization.
>
> Yes, that nasty consequence should be a kernel oops, and the
> developer should notice that before submitting the driver for
> inclusion. I don't think we really care to return an error here
> if this happens.

+1

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2017-12-19 09:52    [W:0.068 / U:2.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site