Messages in this thread | | | Date | Tue, 19 Dec 2017 09:48:19 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink |
| |
On Wed, Dec 13, 2017 at 03:21:22PM -0800, Dmitry Torokhov wrote: > The commit 4a336a23d619 ("kobject: copy env blob in one go") optimized > constructing uevent data for delivery over netlink by using the raw > environment buffer, instead of reconstructing it from individual > environment pointers. Unfortunately in doing so it broke suppressing > MODALIAS attribute for KOBJ_UNBIND events, as the code that suppressed this > attribute only adjusted the environment pointers, but left the buffer > itself alone. Let's fix it by making sure the offending attribute is > obliterated form the buffer as well. > > Reported-by: Tariq Toukan <tariqt@mellanox.com> > Reported-by: Casey Leedom <leedom@chelsio.com> > Fixes: 4a336a23d619 ("kobject: copy env blob in one go") > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > lib/kobject_uevent.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-)
Ok, I'm lost here, is this patch still needed for 4.15-final?
And am I supposed to be taking it through my tree as the offending patch didn't come from me? :)
thanks,
greg k-h
| |