Messages in this thread | | | Date | Wed, 20 Dec 2017 07:39:28 +0800 | From | kbuild test robot <> | Subject | Re: [PATCH 3/3] trace: print address if symbol not found |
| |
Hi Tobin,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc4 next-20171219] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Tobin-C-Harding/kallsyms-don-t-leak-address/20171220-062707 config: i386-randconfig-s1-201751 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386
All errors (new ones prefixed by >>):
kernel/trace/trace_events_hist.c: In function 'hist_trigger_stacktrace_print': >> kernel/trace/trace_events_hist.c:985:3: error: implicit declaration of function 'trace_sprint_symbol_addr' [-Werror=implicit-function-declaration] trace_sprint_symbol_addr(str, stacktrace_entries[i]); ^~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors
vim +/trace_sprint_symbol_addr +985 kernel/trace/trace_events_hist.c
971 972 static void hist_trigger_stacktrace_print(struct seq_file *m, 973 unsigned long *stacktrace_entries, 974 unsigned int max_entries) 975 { 976 char str[KSYM_SYMBOL_LEN]; 977 unsigned int spaces = 8; 978 unsigned int i; 979 980 for (i = 0; i < max_entries; i++) { 981 if (stacktrace_entries[i] == ULONG_MAX) 982 return; 983 984 seq_printf(m, "%*c", 1 + spaces, ' '); > 985 trace_sprint_symbol_addr(str, stacktrace_entries[i]); 986 seq_printf(m, "%s\n", str); 987 } 988 } 989
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [unhandled content-type:application/gzip] | |