lkml.org 
[lkml]   [2017]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] KVM: vmx: speed up MSR bitmap merge
From
Date

>
>>> + nested_vmx_disable_intercept_for_msr(
>>> + msr_bitmap_l1, msr_bitmap_l0,
>>> + APIC_BASE_MSR + (APIC_TASKPRI >> 4),
>>> + MSR_TYPE_W);
>>
>> I'd vote for indenting the parameters properly (even though we exceed 80
>> chars by 1 then :) )
>
> Ok, will do. Regarding the WARN, I'm undecided. I like the idea of not
> calling a function that works on MSR bitmaps unless you have one...

At least from a point of documentation it should be fine:

"return false to indicate that we do not use the hardware"

+gcc will inline this either way.

>
> Paolo
>


--

Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2017-12-18 17:43    [W:0.030 / U:1.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site