lkml.org 
[lkml]   [2017]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 12/69] usb: phy: isp1301: Add OF device ID table
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Javier Martinez Canillas <javier@osg.samsung.com>


    [ Upstream commit fd567653bdb908009b650f079bfd4b63169e2ac4 ]

    The driver doesn't have a struct of_device_id table but supported devices
    are registered via Device Trees. This is working on the assumption that a
    I2C device registered via OF will always match a legacy I2C device ID and
    that the MODALIAS reported will always be of the form i2c:<device>.

    But this could change in the future so the correct approach is to have an
    OF device ID table if the devices are registered via OF.

    Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/phy/phy-isp1301.c | 7 +++++++
    1 file changed, 7 insertions(+)

    --- a/drivers/usb/phy/phy-isp1301.c
    +++ b/drivers/usb/phy/phy-isp1301.c
    @@ -32,6 +32,12 @@ static const struct i2c_device_id isp130
    { }
    };

    +static const struct of_device_id isp1301_of_match[] = {
    + {.compatible = "nxp,isp1301" },
    + { },
    +};
    +MODULE_DEVICE_TABLE(of, isp1301_of_match);
    +
    static struct i2c_client *isp1301_i2c_client;

    static int __isp1301_write(struct isp1301 *isp, u8 reg, u8 value, u8 clear)
    @@ -129,6 +135,7 @@ static int isp1301_remove(struct i2c_cli
    static struct i2c_driver isp1301_driver = {
    .driver = {
    .name = DRV_NAME,
    + .of_match_table = of_match_ptr(isp1301_of_match),
    },
    .probe = isp1301_probe,
    .remove = isp1301_remove,

    \
     
     \ /
      Last update: 2017-12-18 16:50    [W:3.958 / U:1.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site