lkml.org 
[lkml]   [2017]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] misc: ad525x_dpot: macros should not use a trailing semicolon
On Fri, Dec 08, 2017 at 01:43:05PM +0530, Dhaval Shah wrote:
> Resolved all the macros should not use a trailing semicolon
> checkpatch warnings. Issue found by checkpatch.
>
> Signed-off-by: Dhaval Shah <dhaval.shah@softnautics.com>
> ---
> drivers/misc/ad525x_dpot.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c
> index 577f5e76c8a8..bc591b7168db 100644
> --- a/drivers/misc/ad525x_dpot.c
> +++ b/drivers/misc/ad525x_dpot.c
> @@ -515,11 +515,11 @@ set_##_name(struct device *dev, \
> #define DPOT_DEVICE_SHOW_SET(name, reg) \
> DPOT_DEVICE_SHOW(name, reg) \
> DPOT_DEVICE_SET(name, reg) \
> -static DEVICE_ATTR(name, S_IWUSR | S_IRUGO, show_##name, set_##name);
> +static DEVICE_ATTR(name, S_IWUSR | S_IRUGO, show_##name, set_##name)

This should be using DEVICE_ATTR_RW() instead of DEVICE_ATTR(), care to
fix that up in a follow-on patch for this driver?

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-12-18 16:02    [W:0.046 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site