Messages in this thread | | | Date | Mon, 18 Dec 2017 16:02:00 +0100 | From | Greg KH <> | Subject | Re: [PATCH 3/3] misc: ad525x_dpot: macros should not use a trailing semicolon |
| |
On Fri, Dec 08, 2017 at 01:43:05PM +0530, Dhaval Shah wrote: > Resolved all the macros should not use a trailing semicolon > checkpatch warnings. Issue found by checkpatch. > > Signed-off-by: Dhaval Shah <dhaval.shah@softnautics.com> > --- > drivers/misc/ad525x_dpot.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c > index 577f5e76c8a8..bc591b7168db 100644 > --- a/drivers/misc/ad525x_dpot.c > +++ b/drivers/misc/ad525x_dpot.c > @@ -515,11 +515,11 @@ set_##_name(struct device *dev, \ > #define DPOT_DEVICE_SHOW_SET(name, reg) \ > DPOT_DEVICE_SHOW(name, reg) \ > DPOT_DEVICE_SET(name, reg) \ > -static DEVICE_ATTR(name, S_IWUSR | S_IRUGO, show_##name, set_##name); > +static DEVICE_ATTR(name, S_IWUSR | S_IRUGO, show_##name, set_##name)
This should be using DEVICE_ATTR_RW() instead of DEVICE_ATTR(), care to fix that up in a follow-on patch for this driver?
thanks,
greg k-h
| |