Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] wil6210: fix build warnings without CONFIG_PM | Date | Mon, 18 Dec 2017 14:36:37 +0000 |
| |
Arnd Bergmann <arnd@arndb.de> writes:
> The #ifdef checks are hard to get right, in this case some functions > should have been left inside a CONFIG_PM_SLEEP check as seen by this > message: > > drivers/net/wireless/ath/wil6210/pcie_bus.c:489:12: error: 'wil6210_pm_resume' defined but not used [-Werror=unused-function] > drivers/net/wireless/ath/wil6210/pcie_bus.c:484:12: error: 'wil6210_pm_suspend' defined but not used [-Werror=unused-function] > > Using an __maybe_unused is easier here, so I'm replacing all the > other #ifdef in this file as well for consistency. > > Fixes: 94162666cd51 ("wil6210: run-time PM when interface down") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
A note to myself (unfortunately patchwork doesn't have any way to add notes to patches): 94162666cd51 is in wireless-drivers-next so this patch should also go to -next.
-- Kalle Valo
| |