Messages in this thread | | | Date | Mon, 18 Dec 2017 10:48:35 +0000 | From | Patrick Bellasi <> | Subject | Re: [PATCH v2 4/4] sched/cpufreq_schedutil: use util_est for OPP selection |
| |
Hi Rafael,
On 16-Dec 03:35, Rafael J. Wysocki wrote: > On Tuesday, December 5, 2017 6:10:18 PM CET Patrick Bellasi wrote: [...]
> > diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c > > index 2f52ec0f1539..465430d99440 100644 > > --- a/kernel/sched/cpufreq_schedutil.c > > +++ b/kernel/sched/cpufreq_schedutil.c > > @@ -183,7 +183,11 @@ static void sugov_get_util(unsigned long *util, unsigned long *max, int cpu) > > > > cfs_max = arch_scale_cpu_capacity(NULL, cpu); > > > > - *util = min(rq->cfs.avg.util_avg, cfs_max); > > + *util = rq->cfs.avg.util_avg; > > I would use a local variable here. > > That *util everywhere looks a bit dirtyish.
Yes, right... will update for the next respin.
> > > + if (sched_feat(UTIL_EST)) > > + *util = max(*util, rq->cfs.util_est_runnable); > > + *util = min(*util, cfs_max); > > + > > *max = cfs_max; > > } > > > >
Cheers Patrick
-- #include <best/regards.h>
Patrick Bellasi
| |