| Date | Fri, 15 Dec 2017 18:20:06 +0100 | From | Michal Suchánek <> | Subject | Re: [PATCH 3/6] cdrom: wait for tray to close |
| |
On Thu, 14 Dec 2017 16:13:52 +0100 Michal Suchanek <msuchanek@suse.de> wrote:
> @@ -2312,7 +2328,8 @@ static int cdrom_ioctl_closetray(struct > cdrom_device_info *cdi) > if (!CDROM_CAN(CDC_CLOSE_TRAY)) > return -ENOSYS; > - return cdi->ops->tray_move(cdi, 0); > + > + return tray_close(cdi);
This change should be skipped. drive_status is optional and tray_close relies on it. In open_for_* functions tray_close is called based on reading the status so it's ok there.
Thanks
Michal
|