Messages in this thread | | | Subject | Re: [PATCH v10 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver | From | Jose Abreu <> | Date | Fri, 15 Dec 2017 11:23:04 +0000 |
| |
Hi Hans,
On 13-12-2017 20:49, Hans Verkuil wrote: > On 13/12/17 15:00, Jose Abreu wrote: >> >> Indeed. I compared the values with the spec and they are not >> correct. Even hsync is wrong. I already corrected in the code the >> hsync but regarding interlace I'm not seeing an easy way to do >> this without using interrupts in each vsync because the register >> I was toggling does not behave as I expected (I misunderstood the >> databook). Maybe we should not detect interlaced modes for now? >> Or not fill the il_ fields? > As I mentioned above you as long as you get a good backporch value you > can deduce from whether it is an odd or even number to which field it > belongs and fill in the other values. So I think you only need to read > these values for one field. > > Filling in good values here (at least as far as is possible since not all > hardware can give it) will help debugging issues, even if you otherwise do > not support interlaced.
Ok, I will fill the fields.
Until the end of January I will be quite busy in another project so if you could review the remaining patches of this series I would appreciate very much ... This way when I have the time I can code all the changes and send them at once.
Thanks and Best Regards, Jose Miguel Abreu
> > Regards, > > Hans
| |