lkml.org 
[lkml]   [2017]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 081/105] block: wake up all tasks blocked in get_request()
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ming Lei <ming.lei@redhat.com>


    [ Upstream commit 34d9715ac1edd50285168dd8d80c972739a4f6a4 ]

    Once blk_set_queue_dying() is done in blk_cleanup_queue(), we call
    blk_freeze_queue() and wait for q->q_usage_counter becoming zero. But
    if there are tasks blocked in get_request(), q->q_usage_counter can
    never become zero. So we have to wake up all these tasks in
    blk_set_queue_dying() first.

    Fixes: 3ef28e83ab157997 ("block: generic request_queue reference counting")
    Signed-off-by: Ming Lei <ming.lei@redhat.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    block/blk-core.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/block/blk-core.c
    +++ b/block/blk-core.c
    @@ -526,8 +526,8 @@ void blk_set_queue_dying(struct request_

    blk_queue_for_each_rl(rl, q) {
    if (rl->rq_pool) {
    - wake_up(&rl->wait[BLK_RW_SYNC]);
    - wake_up(&rl->wait[BLK_RW_ASYNC]);
    + wake_up_all(&rl->wait[BLK_RW_SYNC]);
    + wake_up_all(&rl->wait[BLK_RW_ASYNC]);
    }
    }
    }

    \
     
     \ /
      Last update: 2017-12-15 11:18    [W:4.175 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site