Messages in this thread |  | | From | Michael Ellerman <> | Subject | Re: [PATCH v2 0/2] mm: introduce MAP_FIXED_SAFE | Date | Fri, 15 Dec 2017 20:02:04 +1100 |
| |
Kees Cook <keescook@chromium.org> writes:
> On Wed, Dec 13, 2017 at 1:25 AM, Michal Hocko <mhocko@kernel.org> wrote: >> >> Hi, >> I am resending with some minor updates based on Michael's review and >> ask for inclusion. There haven't been any fundamental objections for >> the RFC [1] nor the previous version [2]. The biggest discussion >> revolved around the naming. There were many suggestions flowing >> around MAP_REQUIRED, MAP_EXACT, MAP_FIXED_NOCLOBBER, MAP_AT_ADDR, >> MAP_FIXED_NOREPLACE etc... > > With this named MAP_FIXED_NOREPLACE (the best consensus we've got on a > name), please consider this series: > > Acked-by: Kees Cook <keescook@chromium.org>
I don't feel like I'm actually qualified to ack the mm and binfmt changes, but everything *looks* correct to me, and you've fixed the flag numbering such that it can go in mman-common.h as I suggested.
So if the name was MAP_FIXED_NOREPLACE I would also be happy with it.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
I can resubmit with the name changed if that's what it takes.
cheers
|  |