Messages in this thread | | | Date | Fri, 15 Dec 2017 20:57:50 -0800 | From | Brian Norris <> | Subject | Re: [PATCH v4 2/2] rtc: cros-ec: add cros-ec-rtc driver. |
| |
On Fri, Nov 10, 2017 at 10:55:53PM +0100, Enric Balletbo i Serra wrote: > From: Stephen Barber <smbarber@chromium.org> > > On platforms with a Chrome OS EC, the EC can function as a simple RTC. > Add a basic driver with this functionality. > > Signed-off-by: Stephen Barber <smbarber@chromium.org> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > Acked-by: Benson Leung <bleung@chromium.org> > --- > drivers/rtc/Kconfig | 10 ++ > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-cros-ec.c | 413 ++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 424 insertions(+) > create mode 100644 drivers/rtc/rtc-cros-ec.c
This isn't quite super-helpful without the CrOS-EC / MFD additions to actually create the device, but it's a good start, and I don't see any problems with it. Any reason this isn't merged? Are the RTC maintainers intendending to merge this, or should Lee (for the MFD header)? I thought normally Lee deferred to other subsystem maintainers when the only "MFD" stuff was a simple header change (such as in patch 1).
Anyway, FWIW:
Reviewed-by: Brian Norris <briannorris@chromium.org> Tested-by: Brian Norris <briannorris@chromium.org>
| |