lkml.org 
[lkml]   [2017]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC
On Thu, Dec 14, 2017 at 09:32:44AM +0000, Charles Keepax wrote:

> Not sure what you mean here but setting up CODEC registers
> directly from the machine driver is probably not ideal. You
> should probably be looking into regmap_register_patch this lets
> you apply a bunch of register settings to the chip every time you
> do a regmap_cache_sync. This is useful for situations like the
> chip has terrible register defaults you want to correct.

Thanks I will keep that in mind. For now our defaults are okay, but
this may come in handy in other drivers. I have removed this bit from
the next version since this can be set by the machine driver and it
makes more sense there since the settings were configuring how the I2S
interfaces were connected.

\
 
 \ /
  Last update: 2017-12-14 23:37    [W:0.078 / U:1.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site