Messages in this thread | | | Date | Thu, 14 Dec 2017 21:44:42 +0100 | From | Boris Brezillon <> | Subject | Re: [PATCH v2 6/7] i3c: master: Add driver for Cadence IP |
| |
On Thu, 14 Dec 2017 12:25:14 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:
> On 12/14/2017 12:17 PM, Boris Brezillon wrote: > >>> + events.events = I3C_CCC_EVENT_HJ | I3C_CCC_EVENT_MR; > >>> + ret = i3c_master_enec_locked(m, I3C_BROADCAST_ADDR, &events); > >>> + if (ret) > >>> + pr_info("Failed to re-enable H-J"); > >> Not very good info... > > What do you mean? Is it the H-J that bothers you (I can replace it by > > 'Hot-Join'), or is it something else? > > Who is the message for? If it's for developers, you could use > pr_debug(). If it's for users, it needs more clarity.
I think it's of interest to anyone including users. If we fail to re-enable Hot-Join that means hotplug is no longer working which is a bad news.
> > Does it print the source of the message? (module name e.g.)
I could replace it by
dev_err(m->parent, "Failed to re-enable Hot-Join");
> and yes, Hot-Join would be better IMO. >
| |