Messages in this thread | | | Date | Thu, 14 Dec 2017 17:42:15 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 6/8 v3] staging: pi433: use defines for shifting register values |
| |
You'll need to resend everything. The thread is too messy.
On Wed, Dec 13, 2017 at 06:44:44PM +0100, Valentin Vidic wrote: > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c > index f77ecd60f43a..0889c65d5a31 100644 > --- a/drivers/staging/pi433/rf69.c > +++ b/drivers/staging/pi433/rf69.c > @@ -340,14 +340,13 @@ enum lnaGain rf69_get_lna_gain(struct spi_device *spi)
The rf69_get_lna_gain() function is never called. Just delete it.
Also the enum lnaGain is just a pointless abstraction which complicates the code needlessly. It will be deleted eventually too.
regards, dan carpenter
| |