Messages in this thread | | | Subject | Re: [PATCH v4 3/3] PCI: endpoint: Fix find_first_zero_bit() usage | From | Kishon Vijay Abraham I <> | Date | Thu, 14 Dec 2017 16:39:52 +0530 |
| |
On Tuesday 12 December 2017 07:46 PM, Niklas Cassel wrote: > find_first_zero_bit()'s parameter 'size' is defined in bits, > not in bytes. > > Calling find_first_zero_bit() with the wrong size unit > will lead to insidious bugs. > > Fix this by calling find_first_zero_bit() with size BITS_PER_LONG, > rather than sizeof() and add missing find_first_zero_bit() return > handling. > > Fixes: d74679911610 ("PCI: endpoint: Introduce configfs entry for configuring EP functions") > Signed-off-by: Niklas Cassel <niklas.cassel@axis.com> > Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
I'll hold Acking this patch, since it is dependent on the previous one.
Thanks Kishon
| |