lkml.org 
[lkml]   [2017]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 15/16] remoteproc: st: associate memory device to memory regions
    On Thu 30 Nov 08:46 PST 2017, Loic Pallardy wrote:

    > Enable memory device creation for each memory region added
    > by rproc_add_carveout function.
    >
    > Signed-off-by: Loic Pallardy <loic.pallardy@st.com>
    > ---
    > drivers/remoteproc/st_remoteproc.c | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c
    > index da42ec9..bf83d82 100644
    > --- a/drivers/remoteproc/st_remoteproc.c
    > +++ b/drivers/remoteproc/st_remoteproc.c
    > @@ -279,6 +279,7 @@ static int st_rproc_parse_dt(struct platform_device *pdev)
    > mem->dma = res.start;
    > mem->da = res.start;
    > mem->len = resource_size(&res);
    > + strncpy(mem->name, node->name, sizeof(mem->name));

    Please add this to the previous patch.

    > mem->va = devm_ioremap_wc(dev, mem->dma, mem->len);
    > if (!mem->va) {
    > dev_err(dev, "Unable to map memory region: %pa+%zx\n",
    > @@ -286,7 +287,7 @@ static int st_rproc_parse_dt(struct platform_device *pdev)
    > return -EBUSY;
    > }
    >
    > - rproc_add_carveout(rproc, mem, false);
    > + rproc_add_carveout(rproc, mem, true);

    Here you can see how easy it is to accidentally double-map the memory
    region.

    Regards,
    Bjorn

    \
     
     \ /
      Last update: 2017-12-14 06:38    [W:4.847 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site