Messages in this thread | | | Date | Thu, 14 Dec 2017 10:31:09 +0900 | From | Andi Shyti <> | Subject | Re: [PATCH v2] spi: s3c64xx: add SPDX identifier |
| |
Hi Philippe,
> > diff --git a/include/linux/platform_data/spi-s3c64xx.h b/include/linux/platform_data/spi-s3c64xx.h > > index da79774078a7..8917f38c97c5 100644 > > --- a/include/linux/platform_data/spi-s3c64xx.h > > +++ b/include/linux/platform_data/spi-s3c64xx.h > > @@ -2,9 +2,7 @@ > > * Copyright (C) 2009 Samsung Electronics Ltd. > > * Jaswinder Singh <jassi.brar@samsung.com> > > * > > - * This program is free software; you can redistribute it and/or modify > > - * it under the terms of the GNU General Public License version 2 as > > - * published by the Free Software Foundation. > > + * SPDX-License-Identifier: GPL-2.0 > > */ > > > > #ifndef __SPI_S3C64XX_H > > -- > > 2.15.1 > > > > > You still need to put this line at the very top of the file, first > line. That's the convention for the SPDX tags as documented by Thomas > Gleixner.
I had some doubts on this one, indeed. How should it be done in this case:
1. Strictly by Thomas documentation:
/* SPDX-License-Identifier: GPL-2.0 */
/* * Copyright (C) 2009 Samsung Electronics Ltd. * Jaswinder Singh <jassi.brar@samsung.com> */
or
2. with a little interpretation
/* * SPDX-License-Identifier: GPL-2.0 * * Copyright (C) 2009 Samsung Electronics Ltd. * Jaswinder Singh <jassi.brar@samsung.com> */
(I opted for the one with the least number of changes)
Thanks, Andi
> > + * SPDX-License-Identifier: GPL-2.0 > > > -- > Cordially > Philippe Ombredanne >
| |