Messages in this thread | | | Subject | Re: [PATCH] leds: as3645a: Fix checkpatch warnings | From | Dan Murphy <> | Date | Wed, 13 Dec 2017 14:49:38 -0600 |
| |
Pavel and Laurent
On 12/13/2017 02:43 PM, Jacek Anaszewski wrote: > Dan, > > On 12/13/2017 09:41 PM, Dan Murphy wrote: >> Jacek >> >> On 12/13/2017 02:29 PM, Jacek Anaszewski wrote: >>> Hi Dan, >>> >>> checkpatch.pl doesn't want to be mentioned in the patch subject :-) >>> >> >> Ack >> >>> "WARNING: A patch subject line should describe the change not the tool >>> that found it" >>> >>> Preferably I'd see two separate patches. >>> >> >> So you want me to split them up? I have no issue with that. > > Yeah, it will be easier to come up with concise but meaningful > subjects. >
When I split these up can I add your Acked-by to each patch or would you prefer to resend your Acked-by for each patch?
Dan
>>> Also, line length limit for the commit description is 75 characters. >>> Please use whole available space. >>> >> >> >
-- ------------------ Dan Murphy
| |